linux-kernel - Re: [PATCH] watchdog: sp5100_tco: Add "action" module parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 19 Sep 2022 13:18:53 +0000
From:   Vladimir Panteleev <git@...dimir.panteleev.md>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Wim Van Sebroeck <wim@...ux-watchdog.org>,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: sp5100_tco: Add "action" module parameter

Hi Guenter,

On Mon, 19 Sept 2022 at 12:29, Guenter Roeck <linux@...ck-us.net> wrote:
> I am not getting into define name editing wars. The define is named as
> it is. There is never a good reason to rename it. If I'd accept your
> change, someone else might come tomorrow and want it renamed to
> "SP5100_WDT_ACTION_POWEROFF" because setting the bit to 1 causes
> the system to power off.

Ah, sorry - this is one of my first attempts at contributing to the
kernel, and as such I of course fully defer to you. In case I was
misunderstood, I was just trying to explain my line of reasoning at
the time, which is what I thought you asked for in your previous
message. Thank you for the explanation, I was not aware of the high
cost of renaming defines.

I will send a V2 if this is all?

Thank you for your time :)
Best regards,
- Vladimir