linux-kernel - Re: [PATCH v2] dt-bindings: firmware: imx: sync with SCFW kit v1.13.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220919132923.qsai4ijitvvto3g4@fsr-ub1664-116>
Date:   Mon, 19 Sep 2022 16:29:23 +0300
From:   Viorel Suman <viorel.suman@....nxp.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Abel Vesa <abelvesa@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Shenwei Wang <shenwei.wang@....com>,
        Viorel Suman <viorel.suman@....com>, linux-clk@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: firmware: imx: sync with SCFW kit v1.13.0

On 22-09-19 13:40:18, Krzysztof Kozlowski wrote:
> On 19/09/2022 13:37, Viorel Suman (OSS) wrote:
> > From: Viorel Suman <viorel.suman@....com>
> > 
> > Sync defines with the latest available SCFW kit version 1.13.0,
> > may be found at the URL below:
> > 
> > https://www.nxp.com/webapp/Download?colCode=L5.15.32_2.0.0_SCFWKIT-1.13.0&appType=license
> > 
> > Signed-off-by: Viorel Suman <viorel.suman@....com>
> > ---
> >  drivers/clk/imx/clk-imx8qm-rsrc.c       |   4 +-
> >  include/dt-bindings/firmware/imx/rsrc.h | 292 ++++++++++++++++--------
> 
> Bindings cannot be squashed with driver change.
> 
> >  2 files changed, 198 insertions(+), 98 deletions(-)
> > 
> > Changes since v1:
> > 	Two patches squashed into one in order to keep changes bissectable
> > 	and compilable as suggested by Alexander Stein.
> 
> That's not the solution. Solution is to make driver behaving correctly,
> not squash patches which must not be together.
> 
> This is proof of an ABI break, so NAK unless described why it is OK to
> break the ABI/users/boards.

Hi Krzysztof,

In v3 I've added two more defines in backward compatibility section in order to
avoid breaking ABI, so there is no need to change the driver anymore.

Regards,
Viorel