linux-kernel - Re: [PATCH] fs/binfmt_flat.c: use __func_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87pmfr5v5a.fsf@email.froward.int.ebiederm.org>
Date:   Mon, 19 Sep 2022 08:52:17 -0500
From:   "Eric W. Biederman" <ebiederm@...ssion.com>
To:     Jiangshan Yi <13667453960@....com>
Cc:     viro@...iv.linux.org.uk, keescook@...omium.org,
        linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Jiangshan Yi <yijiangshan@...inos.cn>
Subject: Re: [PATCH] fs/binfmt_flat.c: use __func__ instead of function name

Jiangshan Yi <13667453960@....com> writes:

> From: Jiangshan Yi <yijiangshan@...inos.cn>
>
> It is better to use __func__ instead of function name.

Why?

Usually we leave these kinds of stylistic decisions to the people
actually working on and maintaining the code.

Unless this message is likely to be copied to another function
and it very much does not look like it is, this kind of change
looks like it will just make grepping for the error message more
difficult.

Not that I am working on the code and can speak but this just feels like
a gratuitous change to me and so I am asking questions to make certain
it is actually worth making.

Eric


> Signed-off-by: Jiangshan Yi <yijiangshan@...inos.cn>
> ---
>  fs/binfmt_flat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c
> index c26545d71d39..4104c824e7b1 100644
> --- a/fs/binfmt_flat.c
> +++ b/fs/binfmt_flat.c
> @@ -184,7 +184,7 @@ static int decompress_exec(struct linux_binprm *bprm, loff_t fpos, char *dst,
>  	z_stream strm;
>  	int ret, retval;
>  
> -	pr_debug("decompress_exec(offset=%llx,buf=%p,len=%lx)\n", fpos, dst, len);
> +	pr_debug("%s(offset=%llx,buf=%p,len=%lx)\n", __func__, fpos, dst, len);
>  
>  	memset(&strm, 0, sizeof(strm));
>  	strm.workspace = kmalloc(zlib_inflate_workspacesize(), GFP_KERNEL);