linux-kernel - Re: [PATCH v2 1/1] serial: 8250: Turn IER bits on only after irq has been set up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f55fafa9-c957-f7ee-ea49-475ba5f96d9@linux.intel.com>
Date:   Mon, 19 Sep 2022 17:06:56 +0300 (EEST)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
cc:     Lennert Buytenhek <buytenh@...tstofly.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Aristeu Sergio Rozanski Filho <aris@...hedrallabs.org>,
        Alex Williamson <alex.williamson@...com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-serial <linux-serial@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Lennert Buytenhek <buytenh@...sta.com>
Subject: Re: [PATCH v2 1/1] serial: 8250: Turn IER bits on only after irq
 has been set up

On Mon, 19 Sep 2022, Andy Shevchenko wrote:

> On Fri, Sep 16, 2022 at 06:44:49PM +0300, Andy Shevchenko wrote:
> > On Fri, Sep 16, 2022 at 06:36:16PM +0300, Andy Shevchenko wrote:
> > > On Fri, Sep 16, 2022 at 04:38:04PM +0300, Ilpo Järvinen wrote:
> > 
> > Side note:
> > 
> > $ git grep -n -w setup_irq -- drivers/tty/
> > drivers/tty/serial/8250/8250_core.c:382:        .setup_irq      = univ8250_setup_irq,
> > drivers/tty/serial/8250/8250_port.c:2341:       retval = up->ops->setup_irq(up);
> > 
> > which rises a question of whether we need the setup_irq member in the
> > respective structure.
> 
> And to be confident, the files that include linux/serial_8250.h and have
> setup_irq word in them (recursive `git grep`) in entire source tree:
> 
> drivers/tty/serial/8250/8250_core.c
> drivers/tty/serial/8250/8250_port.c
> include/linux/serial_8250.h

Thanks. I know about it already.

The whole struct uart_8250_ops seems useless indirection layer (and 
IIRC the results of my history dig, it was added w/o any justification). 
It's on my kill list already :-) but I'll wait a bit with the cleanups to 
avoid -linus vs -next conflicts.

-- 
 i.