linux-kernel - Re: [PATCH] media: i2c: ov5645: Drop fetching the clk reference by name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 19 Sep 2022 17:42:38 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Prabhakar <prabhakar.csengg@...il.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Jacopo Mondi <jacopo@...ndi.org>, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH] media: i2c: ov5645: Drop fetching the clk reference by
 name

Hi Prabhakar,

Thank you for the patch.

On Mon, Sep 19, 2022 at 03:33:50PM +0100, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> 
> The OV5645 sensor has a single clock source, so just drop fetching the
> clk reference by name.
> 
> This is in preparation to drop the "clock-names" property from the DT
> binding.
> 
> Suggested-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>

> ---
>  drivers/media/i2c/ov5645.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c
> index 81e4e87e1821..47451238ca05 100644
> --- a/drivers/media/i2c/ov5645.c
> +++ b/drivers/media/i2c/ov5645.c
> @@ -1090,7 +1090,7 @@ static int ov5645_probe(struct i2c_client *client)
>  	}
>  
>  	/* get system clock (xclk) */
> -	ov5645->xclk = devm_clk_get(dev, "xclk");
> +	ov5645->xclk = devm_clk_get(dev, NULL);
>  	if (IS_ERR(ov5645->xclk)) {
>  		dev_err(dev, "could not get xclk");
>  		return PTR_ERR(ov5645->xclk);

-- 
Regards,

Laurent Pinchart