linux-kernel - Re: [PATCH -next] MIPS: SGI-IP27: Fix platform-device leak in bridge_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220919144831.GC7674@alpha.franken.de>
Date:   Mon, 19 Sep 2022 16:48:31 +0200
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Lin Yujun <linyujun809@...wei.com>
Cc:     christophe.jaillet@...adoo.fr, paulburton@...nel.org,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] MIPS: SGI-IP27: Fix platform-device leak in
 bridge_platform_create()

On Wed, Sep 14, 2022 at 11:29:17AM +0800, Lin Yujun wrote:
> In error case in bridge_platform_create after calling
> platform_device_add()/platform_device_add_data()/
> platform_device_add_resources(), release the failed
> 'pdev' or it will be leak, call platform_device_put()
> to fix this problem.
> 
> Besides, 'pdev' is divided into 'pdev_wd' and 'pdev_bd',
> use platform_device_unregister() to release sgi_w1
> resources when xtalk-bridge registration fails.
> 
> Fixes: 5dc76a96e95a ("MIPS: PCI: use information from 1-wire PROM for IOC3 detection")
> Signed-off-by: Lin Yujun <linyujun809@...wei.com>
> ---
>  arch/mips/sgi-ip27/ip27-xtalk.c | 70 +++++++++++++++++++++++----------
>  1 file changed, 50 insertions(+), 20 deletions(-)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]