linux-kernel - Re: [PATCH v2 1/3] Added platform module alias for the xiic I2C driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c5fd7a8-523b-100c-a104-d2f0bf69be16@amd.com>
Date:   Tue, 20 Sep 2022 16:30:44 +0200
From:   Michal Simek <michal.simek@....com>
To:     <tumic@...see.org>, Mauro Carvalho Chehab <mchehab@...nel.org>,
        Vinod Koul <vkoul@...nel.org>,
        Michal Simek <michal.simek@...inx.com>,
        "Sreeram, Manikanta" <manikanta.sreeram@....com>
CC:     <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <dmaengine@...r.kernel.org>, <linux-i2c@...r.kernel.org>,
        Martin Tůma <martin.tuma@...iteqautomotive.com>
Subject: Re: [PATCH v2 1/3] Added platform module alias for the xiic I2C
 driver



On 9/19/22 20:55, tumic@...see.org wrote:
> From: Martin Tůma <martin.tuma@...iteqautomotive.com>

Subject should contain subsystem prefix and driver.

i2c: xiic: is commonly used in this driver.

> 
> The missing "platform" alias is required for the mgb4 v4l2 driver to load
> the i2c controller driver when probing the HW.
> 
> Signed-off-by: Martin Tůma <martin.tuma@...iteqautomotive.com>
> ---
>   drivers/i2c/busses/i2c-xiic.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> index b3fe6b2aa3ca..277a02455cdd 100644
> --- a/drivers/i2c/busses/i2c-xiic.c
> +++ b/drivers/i2c/busses/i2c-xiic.c
> @@ -920,6 +920,7 @@ static struct platform_driver xiic_i2c_driver = {
> 
>   module_platform_driver(xiic_i2c_driver);
> 
> +MODULE_ALIAS("platform:" DRIVER_NAME);
>   MODULE_AUTHOR("info@...ean-labs.com");
>   MODULE_DESCRIPTION("Xilinx I2C bus driver");
>   MODULE_LICENSE("GPL v2");
> --
> 2.37.2
> 

Change is fine.

Thanks,
Michal