linux-kernel - Re: [PATCH net-next 05/13] sunhme: Regularize probe errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Sep 2022 12:36:37 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Sean Anderson <seanga2@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org (open list),
        Zheyu Ma <zheyuma97@...il.com>,
        Nick Bowler <nbowler@...conx.ca>,
        Rolf Eike Beer <eike-kernel@...tec.de>
Subject: Re: [PATCH net-next 05/13] sunhme: Regularize probe errors

On Sun, 18 Sep 2022 19:26:18 -0400 Sean Anderson wrote:
> -	err = -ENODEV;
> +	err = -EINVAL;
>  	if ((pci_resource_flags(pdev, 0) & IORESOURCE_IO) != 0) {
>  		printk(KERN_ERR "happymeal(PCI): Cannot find proper PCI device base address.\n");
>  		goto err_out_clear_quattro;
>  	}

Why not move it inside the if?