linux-kernel - Re: [PATCH v1] net/ethtool/tunnels: check the return value of nla_nest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Sep 2022 12:41:48 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Li Zhong <floridsleeves@...il.com>
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        pabeni@...hat.com, edumazet@...gle.com, davem@...emloft.net
Subject: Re: [PATCH v1] net/ethtool/tunnels: check the return value of
 nla_nest_start()

On Tue, 20 Sep 2022 12:31:29 -0700 Li Zhong wrote:
> On Tue, Sep 20, 2022 at 11:37 AM Jakub Kicinski <kuba@...nel.org> wrote:
> > On Fri, 16 Sep 2022 19:26:02 -0700 Li Zhong wrote:  
> > >                       goto err_cancel_table;
> > >
> > >               entry = nla_nest_start(skb, ETHTOOL_A_TUNNEL_UDP_TABLE_ENTRY);
> > > +             if (!entry)
> > > +                     return -EMSGSIZE;  
> >
> > not even correct, and completely harmless  
> 
> Thanks for your reply. Maybe a more suitable way of error handling is 'goto
> err_cancel_table;'?

Yes, but you _most_ provide the detailed analysis of the impact 
in the commit message for the patches to be considered for merging.