[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <67b11e85-3e4e-beb7-4a2b-ef856207b227@opensource.wdc.com>
Date: Wed, 21 Sep 2022 07:03:33 +0900
From: Damien Le Moal <damien.lemoal@...nsource.wdc.com>
To: John Garry <john.garry@...wei.com>, jejb@...ux.ibm.com,
martin.petersen@...cle.com, hare@...e.de, hch@....de
Cc: linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-scsi@...r.kernel.org, brking@...ibm.com
Subject: Re: [PATCH 1/6] scsi: core: Use SCSI_SCAN_RESCAN in
__scsi_add_device()
On 9/20/22 19:27, John Garry wrote:
> Instead of using hardcoded '1' as the __scsi_add_device() ->
> scsi_probe_and_add_lun() rescan arg, use proper macro SCSI_SCAN_RESCAN.
>
> Signed-off-by: John Garry <john.garry@...wei.com>
> ---
> drivers/scsi/scsi_scan.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
> index ac6059702d13..3759b1a77504 100644
> --- a/drivers/scsi/scsi_scan.c
> +++ b/drivers/scsi/scsi_scan.c
> @@ -1588,7 +1588,8 @@ struct scsi_device *__scsi_add_device(struct Scsi_Host *shost, uint channel,
> scsi_complete_async_scans();
>
> if (scsi_host_scan_allowed(shost) && scsi_autopm_get_host(shost) == 0) {
> - scsi_probe_and_add_lun(starget, lun, NULL, &sdev, 1, hostdata);
> + scsi_probe_and_add_lun(starget, lun, NULL, &sdev,
> + SCSI_SCAN_RESCAN, hostdata);
> scsi_autopm_put_host(shost);
> }
> mutex_unlock(&shost->scan_mutex);
Looks good.
Reviewed-by: Damien Le Moal <damien.lemoal@...nsource.wdc.com>
--
Damien Le Moal
Western Digital Research
Powered by blists - more mailing lists