linux-kernel - Re: [PATCH v3 2/2] input: touchscreen: elants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yyk/b29aG2ivpkf5@google.com>
Date:   Mon, 19 Sep 2022 21:19:59 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Yunlong Jia <yunlong.jia@....corp-partner.google.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Henry Sun <henrysun@...gle.com>,
        Douglas Anderson <dianders@...omium.org>,
        Bob Moragues <moragues@...omium.org>,
        Yunlong Jia <yunlong.jia@....com.tw>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Johnny Chuang <johnny.chuang.emc@...il.com>,
        linux-input@...r.kernel.org
Subject: Re: [PATCH v3 2/2] input: touchscreen: elants_i2c: Add eth3915n
 touchscreen chip

Hi Yunlong,

On Fri, Sep 09, 2022 at 10:27:55AM +0000, Yunlong Jia wrote:
> The eth3915n requires more delay time than the eth3500 when poweron
>  & reset.
> Define EKTH3915_POWERON_DELAY_MSEC as the poweron delay time of eth3915n,
>  about 80ms.
> Define EKTH3915_RESET_DELAY_MSEC as the reset delay time of eth3915n,
>  about 300ms.
> 
> Signed-off-by: Yunlong Jia <yunlong.jia@....com.tw>
> Reviewed-by: Douglas Anderson <dianders@...omium.org>
> 
> ---
> 
> Changes in v3:
>  1. Add poweron delay time.

This materially changes the patch so I do not believe you should have
kept Doug's reviewed-by tag. I also do not understand what this delay is
for. Is this the minimal time for the reset line to stay high? Something
else?

Thanks.

-- 
Dmitry