linux-kernel - Re: [PATCH v4 03/10] tty: serial: altera_uart_{r,t}x_chars() need only uart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <259b72f4-21d9-7575-784c-63b534e7a9c5@linux.intel.com>
Date:   Tue, 20 Sep 2022 11:04:13 +0300 (EEST)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Jiri Slaby <jslaby@...e.cz>
cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial <linux-serial@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Tobias Klauser <tklauser@...tanz.ch>
Subject: Re: [PATCH v4 03/10] tty: serial: altera_uart_{r,t}x_chars() need
 only uart_port

On Tue, 20 Sep 2022, Jiri Slaby wrote:

> Both altera_uart_{r,t}x_chars() need only uart_port, not altera_uart. So
> pass the former from altera_uart_interrupt() directly.
> 
> Apart it maybe saves a dereference, this makes the transition of
> altera_uart_tx_chars() easier to follow in the next patch.
> 
> Cc: Tobias Klauser <tklauser@...tanz.ch>
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
 i.