linux-kernel - Re: [PATCH 1/3] libfs: add DEFINE_SIMPLE_ATTRIBUTE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Sep 2022 10:14:56 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Akinobu Mita <akinobu.mita@...il.com>, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-kselftest@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        corbet@....net, osalvador@...e.de, shuah@...nel.org,
        Zhao Gongyi <zhaogongyi@...wei.com>,
        Wei Yongjun <weiyongjun1@...wei.com>,
        Yicong Yang <yangyicong@...ilicon.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        akpm@...ux-foundation.org
Subject: Re: [PATCH 1/3] libfs: add DEFINE_SIMPLE_ATTRIBUTE_SIGNED for signed
 value

On 19.09.22 19:24, Akinobu Mita wrote:
> The simple attribute files do not accept a negative value since the
> commit 488dac0c9237 ("libfs: fix error cast of negative value in
> simple_attr_write()"), so we have to use a 64-bit value to write a
> negative value.
> 
> This adds DEFINE_SIMPLE_ATTRIBUTE_SIGNED for a signed value.
> 
> Fixes: 488dac0c9237 ("libfs: fix error cast of negative value in simple_attr_write()")

This patch itself isn't a fix. The fixes tags belong to the other 
patches that make use of this.

> Reported-by: Zhao Gongyi <zhaogongyi@...wei.com>
> Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>
> ---

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb