linux-kernel - Re: [PATCH] KVM: s390: pci: fix GAIT physical vs virtual pointers usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8b8eb1d8-a8ae-d57f-559f-5e9d0fc981b9@linux.ibm.com>
Date:   Tue, 20 Sep 2022 10:25:54 +0200
From:   Janosch Frank <frankja@...ux.ibm.com>
To:     Matthew Rosato <mjrosato@...ux.ibm.com>, linux-s390@...r.kernel.org
Cc:     nrb@...ux.ibm.com, pmorel@...ux.ibm.com, schnelle@...ux.ibm.com,
        farman@...ux.ibm.com, borntraeger@...ux.ibm.com, hca@...ux.ibm.com,
        gor@...ux.ibm.com, agordeev@...ux.ibm.com, svens@...ux.ibm.com,
        david@...hat.com, imbrenda@...ux.ibm.com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: s390: pci: fix GAIT physical vs virtual pointers
 usage

On 9/7/22 17:59, Matthew Rosato wrote:
> The GAIT and all of its entries must be represented by physical
> addresses as this structure is shared with underlying firmware.
> We can keep a virtual address of the GAIT origin in order to
> handle processing in the kernel, but when traversing the entries
> we must again convert the physical AISB stored in that GAIT entry
> into a virtual address in order to process it.
> 
> Note: this currently doesn't fix a real bug, since virtual addresses
> are indentical to physical ones.
> 
> Reviewed-by: Pierre Morel <pmorel@...ux.ibm.com>
> Acked-by: Nico Boehr <nrb@...ux.ibm.com>
> Signed-off-by: Matthew Rosato <mjrosato@...ux.ibm.com>

Thanks, applied