linux-kernel - Re: [PATCH v4 06/10] tty: serial: switch mpc52xx_uart_int_{r,t}x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5918019-2abc-acd4-7171-54ad2a81854@linux.intel.com>
Date:   Tue, 20 Sep 2022 11:37:06 +0300 (EEST)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Jiri Slaby <jslaby@...e.cz>
cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial <linux-serial@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 06/10] tty: serial: switch mpc52xx_uart_int_{r,t}x_chars()
 to bool

On Tue, 20 Sep 2022, Jiri Slaby wrote:

> mpc52xx_uart_int_rx_chars() returns unsigned int.
> mpc52xx_uart_int_tx_chars() returns int.
> 
> The both results are binary ORed to the "keepgoing" variable. Unify all
> three to bool as the only interesting value is whether we should keep
> looping (true/false).
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
 i.