lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Sep 2022 14:27:20 +0530 From: Bhupesh Sharma <bhupesh.sharma@...aro.org> To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org Cc: agross@...nel.org, linux-kernel@...r.kernel.org, robh+dt@...nel.org, thara.gopinath@...il.com, devicetree@...r.kernel.org, robh@...nel.org, andersson@...nel.org, bhupesh.linux@...il.com, catalin.marinas@....com, will@...nel.org, arnd@...db.de, Jordan Crouse <jorcrous@...zon.com> Subject: Re: [PATCH v6 1/4 RESEND] ARM: dts: qcom: Use new compatibles for crypto nodes On 9/20/22 12:55 PM, Krzysztof Kozlowski wrote: > On 20/09/2022 00:15, Bhupesh Sharma wrote: >> Since we are using soc specific qce crypto IP compatibles >> in the bindings now, use the same in the device tree files >> which include the crypto nodes. >> >> Cc: Bjorn Andersson <andersson@...nel.org> >> Cc: Rob Herring <robh@...nel.org> >> Tested-by: Jordan Crouse <jorcrous@...zon.com> >> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@...aro.org> >> --- >> arch/arm/boot/dts/qcom-ipq4019.dtsi | 2 +- >> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +- >> arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 +- >> arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- >> arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- >> 5 files changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom-ipq4019.dtsi >> index b23591110bd2..9c40714562d5 100644 >> --- a/arch/arm/boot/dts/qcom-ipq4019.dtsi >> +++ b/arch/arm/boot/dts/qcom-ipq4019.dtsi >> @@ -314,7 +314,7 @@ cryptobam: dma-controller@...4000 { >> }; >> >> crypto: crypto@...a000 { >> - compatible = "qcom,crypto-v5.1"; >> + compatible = "qcom,ipq4019-qce"; > > There are few issues here: > 1. Compatible is not documented. Its documented here: https://lore.kernel.org/linux-arm-msm/30756e6f-952f-ccf2-b493-e515ba4f0a64@linaro.org/ [as mentioned in the dependency section in the cover letter :)] > 2. Compatible is not supported by old kernel - ABI break. > 3. Everything won't be bisectable... I think its a question of dependencies b/w the patchsets intended for separate areas. Let me think more on how, I can resolve it in newer versions. Thanks, Bhupesh > The same in other places. > > Best regards, > Krzysztof
Powered by blists - more mailing lists