linux-kernel - [PATCH v14 08/13] dm-zoned: ensure only power of 2 zone sizes are allowed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220920091119.115879-9-p.raghav@samsung.com>
Date:   Tue, 20 Sep 2022 11:11:14 +0200
From:   Pankaj Raghav <p.raghav@...sung.com>
To:     agk@...hat.com, snitzer@...nel.org, axboe@...nel.dk,
        damien.lemoal@...nsource.wdc.com, hch@....de
Cc:     gost.dev@...sung.com, jaegeuk@...nel.org,
        Johannes.Thumshirn@....com, hare@...e.de, bvanassche@....org,
        dm-devel@...hat.com, matias.bjorling@....com,
        linux-kernel@...r.kernel.org, linux-nvme@...ts.infradead.org,
        pankydev8@...il.com, linux-block@...r.kernel.org,
        Luis Chamberlain <mcgrof@...nel.org>,
        Johannes Thumshirn <johannes.thumshirn@....com>,
        Pankaj Raghav <p.raghav@...sung.com>
Subject: [PATCH v14 08/13] dm-zoned: ensure only power of 2 zone sizes are
 allowed

From: Luis Chamberlain <mcgrof@...nel.org>

dm-zoned relies on the assumption that the zone size is a
power-of-2(po2) and the zone capacity is same as the zone size.

Ensure only po2 devices can be used as dm-zoned target until a native
support for zoned devices with non-po2 zone size is added.

Reviewed-by: Hannes Reinecke <hare@...e.de>
Reviewed-by: Damien Le Moal <damien.lemoal@...nsource.wdc.com>
Reviewed-by: Bart Van Assche <bvanassche@....org>
Reviewed-by: Mike Snitzer <snitzer@...nel.org>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@....com>
Signed-off-by: Luis Chamberlain <mcgrof@...nel.org>
Signed-off-by: Pankaj Raghav <p.raghav@...sung.com>
---
 drivers/md/dm-zoned-target.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/md/dm-zoned-target.c b/drivers/md/dm-zoned-target.c
index 95b132b52f33..9325bf5dee81 100644
--- a/drivers/md/dm-zoned-target.c
+++ b/drivers/md/dm-zoned-target.c
@@ -792,6 +792,10 @@ static int dmz_fixup_devices(struct dm_target *ti)
 				return -EINVAL;
 			}
 			zone_nr_sectors = bdev_zone_sectors(bdev);
+			if (!is_power_of_2(zone_nr_sectors)) {
+				ti->error = "Zone size is not a power-of-2 number of sectors";
+				return -EINVAL;
+			}
 			zoned_dev->zone_nr_sectors = zone_nr_sectors;
 			zoned_dev->nr_zones = bdev_nr_zones(bdev);
 		}
@@ -804,6 +808,10 @@ static int dmz_fixup_devices(struct dm_target *ti)
 			return -EINVAL;
 		}
 		zoned_dev->zone_nr_sectors = bdev_zone_sectors(bdev);
+		if (!is_power_of_2(zoned_dev->zone_nr_sectors)) {
+			ti->error = "Zone size is not a power-of-2 number of sectors";
+			return -EINVAL;
+		}
 		zoned_dev->nr_zones = bdev_nr_zones(bdev);
 	}
 
-- 
2.25.1