linux-kernel - Re: [PATCH] scsi: ufs-bsg: Remove ufs_bsg_get_query_desc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87e6fdb49d9d76c468712e1b42cbc130273b5635.camel@gmail.com>
Date:   Tue, 20 Sep 2022 11:38:20 +0200
From:   Bean Huo <huobean@...il.com>
To:     Arthur Simchaev <Arthur.Simchaev@....com>, James@...r.kernel.org,
        E.J.Bottomley@...r.kernel.org, jejb@...ux.vnet.ibm.com,
        Martin@...r.kernel.org, K.Petersen@...r.kernel.org,
        martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Bean@...r.kernel.org, Huo@...r.kernel.org, beanhuo@...ron.com
Subject: Re: [PATCH] scsi: ufs-bsg: Remove ufs_bsg_get_query_desc_size
 function

Hi Arthur,


On Mon, 2022-06-20 at 15:26 +0300, Arthur Simchaev wrote:
> The bsg driver allows user space to send device management commands.
> As such, it is often used by field application engineers to debug
> various problems,
> and as a test bed for new features as well.
> 
> Let's not bound ourself to hard coded descriptor sizes, as the new

UFS descriptor size is no longer hardcoded (defined in the driver), the
size of the descriptor is reported by UFS itself, check the latest
kernel.


> Descriptors that supports new features are not defined yet.
> 
> Signed-off-by: Arthur Simchaev <Arthur.Simchaev@....com>
> ---
>  drivers/scsi/ufs/ufs_bsg.c | 28 ++++------------------------
>  1 file changed, 4 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufs_bsg.c b/drivers/scsi/ufs/ufs_bsg.c

This UFS driver is in the wrong location, I assume you are using an
older kernel version?

Kind regards,
Bean