lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Sep 2022 17:45:00 +0800 From: Huisong Li <lihuisong@...wei.com> To: <linux-acpi@...r.kernel.org>, <linux-kernel@...r.kernel.org> CC: <rafael@...nel.org>, <sudeep.holla@....com>, <rafael.j.wysocki@...el.com>, <wanghuiqiang@...wei.com>, <huangdaode@...wei.com>, <lihuisong@...wei.com> Subject: [PATCH 2/2] ACPI: PCC: fix Tx done interface in handler A error, "Client can't run the TX ticker", is printed even if PCC command executed successfully. This root cause is that PCC handler calls 'mbox_client_txdone()' which depands on the client can received 'ACK' packet. But PCC handler detects whether the command is complete through the Tx ACK interrupt. So this patch fix it. Fixes: 77e2a04745ff ("ACPI: PCC: Implement OperationRegion handler for the PCC Type 3 subtype") Signed-off-by: Huisong Li <lihuisong@...wei.com> --- drivers/acpi/acpi_pcc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/acpi_pcc.c b/drivers/acpi/acpi_pcc.c index a1052fe998bf..95d2dc274bd9 100644 --- a/drivers/acpi/acpi_pcc.c +++ b/drivers/acpi/acpi_pcc.c @@ -118,7 +118,7 @@ acpi_pcc_address_space_handler(u32 function, acpi_physical_address addr, } } - mbox_client_txdone(data->pcc_chan->mchan, ret); + mbox_chan_txdone(data->pcc_chan->mchan, ret); memcpy_fromio(value, data->pcc_comm_addr, data->ctx.length); -- 2.33.0
Powered by blists - more mailing lists