lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Sep 2022 12:58:04 +0200 From: Jiri Slaby <jirislaby@...nel.org> To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-serial <linux-serial@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, Russell King <linux@...linux.org.uk>, Florian Fainelli <f.fainelli@...il.com>, bcm-kernel-feedback-list@...adcom.com, Pali Rohár <pali@...nel.org>, Kevin Cernekee <cernekee@...il.com>, Palmer Dabbelt <palmer@...belt.com>, Paul Walmsley <paul.walmsley@...ive.com>, Orson Zhai <orsonzhai@...il.com>, Baolin Wang <baolin.wang7@...il.com>, Chunyan Zhang <zhang.lyra@...il.com>, Patrice Chotard <patrice.chotard@...s.st.com>, linux-riscv@...ts.infradead.org Subject: Re: [PATCH v4 10/10] tty: serial: use uart_port_tx_limited() On 20. 09. 22, 11:19, Ilpo Järvinen wrote: > One improvement suggestion below. > >> diff --git a/drivers/tty/serial/altera_jtaguart.c b/drivers/tty/serial/altera_jtaguart.c >> index 23f339757894..f224f5141726 100644 >> --- a/drivers/tty/serial/altera_jtaguart.c >> +++ b/drivers/tty/serial/altera_jtaguart.c >> @@ -137,39 +137,17 @@ static void altera_jtaguart_rx_chars(struct altera_jtaguart *pp) >> static void altera_jtaguart_tx_chars(struct altera_jtaguart *pp) ... >> + space = readl(port->membase + ALTERA_JTAGUART_CONTROL_REG); >> + space &= ALTERA_JTAGUART_CONTROL_WSPACE_MSK; >> + space >>= ALTERA_JTAGUART_CONTROL_WSPACE_OFF; > > This is FIELD_GET(ALTERA_JTAGUART_CONTROL_WSPACE_MSK, ...) & then allows > killing ALTERA_JTAGUART_CONTROL_WSPACE_OFF. I'd probably do it in a > separate patch though. Right. Prepared for v5. thanks, -- js suse labs
Powered by blists - more mailing lists