linux-kernel - [PATCH v7 7/9] crypto: qce: core: Make clocks optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Sep 2022 17:10:49 +0530
From:   Bhupesh Sharma <bhupesh.sharma@...aro.org>
To:     linux-crypto@...r.kernel.org, devicetree@...r.kernel.org
Cc:     agross@...nel.org, herbert@...dor.apana.org.au,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        linux-arm-msm@...r.kernel.org, thara.gopinath@...il.com,
        robh@...nel.org, krzysztof.kozlowski@...aro.org,
        andersson@...nel.org, bhupesh.sharma@...aro.org,
        bhupesh.linux@...il.com, davem@...emloft.net,
        Jordan Crouse <jorcrous@...zon.com>
Subject: [PATCH v7 7/9] crypto: qce: core: Make clocks optional

From: Thara Gopinath <thara.gopinath@...il.com>

On certain Snapdragon processors, the crypto engine clocks are enabled by
default by security firmware and the driver need not/ should not handle the
clocks. Make acquiring of all the clocks optional in crypto engine driver
so that the driver initializes properly even if no clocks are specified in
the dt.

Cc: Bjorn Andersson <andersson@...nel.org>
Cc: Rob Herring <robh@...nel.org>
Cc: herbert@...dor.apana.org.au
Tested-by: Jordan Crouse <jorcrous@...zon.com>
Signed-off-by: Thara Gopinath <thara.gopinath@...il.com>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@...aro.org>
[Bhupesh: Massage the commit log]
---
 drivers/crypto/qce/core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c
index 99ed540611ab..ef774f6edb5a 100644
--- a/drivers/crypto/qce/core.c
+++ b/drivers/crypto/qce/core.c
@@ -213,15 +213,15 @@ static int qce_crypto_probe(struct platform_device *pdev)
 	if (IS_ERR(qce->mem_path))
 		return PTR_ERR(qce->mem_path);
 
-	qce->core = devm_clk_get(qce->dev, "core");
+	qce->core = devm_clk_get_optional(qce->dev, "core");
 	if (IS_ERR(qce->core))
 		return PTR_ERR(qce->core);
 
-	qce->iface = devm_clk_get(qce->dev, "iface");
+	qce->iface = devm_clk_get_optional(qce->dev, "iface");
 	if (IS_ERR(qce->iface))
 		return PTR_ERR(qce->iface);
 
-	qce->bus = devm_clk_get(qce->dev, "bus");
+	qce->bus = devm_clk_get_optional(qce->dev, "bus");
 	if (IS_ERR(qce->bus))
 		return PTR_ERR(qce->bus);
 
-- 
2.37.1