linux-kernel - Re: [PATCH] drm/amdgpu: initialize r variable into amdgpu_cs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f5b5b001-a1c7-bfa4-1b59-04c439fc9ace@amd.com>
Date:   Tue, 20 Sep 2022 14:57:37 +0200
From:   Christian König <christian.koenig@....com>
To:     Tommaso Merciai <tommaso.merciai@...rulasolutions.com>,
        Christian König <christian.koenig@....com>
Cc:     Andrey Grodzovsky <andrey.grodzovsky@....com>,
        llvm@...ts.linux.dev, Philip Yang <Philip.Yang@....com>,
        David Airlie <airlied@...ux.ie>, linuxfancy@...glegroups.com,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        linux-kernel@...r.kernel.org, amd-gfx@...ts.freedesktop.org,
        Nathan Chancellor <nathan@...nel.org>,
        Luben Tuikov <luben.tuikov@....com>,
        dri-devel@...ts.freedesktop.org, Daniel Vetter <daniel@...ll.ch>,
        Tom Rix <trix@...hat.com>,
        Alex Deucher <alexander.deucher@....com>,
        linux-amarula@...rulasolutions.com, sudipm.mukherjee@...il.com
Subject: Re: [PATCH] drm/amdgpu: initialize r variable into amdgpu_cs_submit
 function

Am 20.09.22 um 14:32 schrieb Tommaso Merciai:
> Hi Christian,
>
> On Tue, Sep 20, 2022 at 02:23:58PM +0200, Christian König wrote:
>> Am 20.09.22 um 14:22 schrieb Tommaso Merciai:
>>> The builds of arm64 allmodconfig with clang failed to build
>>> next-20220920 with the following result:
>>>
>>> 1190:3: error: variable 'r' is uninitialized when used here [-Werror,-Wuninitialized]
>>> note: initialize the variable 'r' to silence this warning
>>>
>>> This fix compilation error
>> I've already send a patch to fix this to the mailing list 7 Minutes ago :)
>>
>> Please review or ack that one.
> Sorry, my bad. Don't see your patch :)

No problem, already reviewed and pushed :)

It probably takes a moment for the mailing list to deliver the patch to 
everybody.

Cheers,
Christian.

>
> Cheers,
> Tommaso
>
>> Thanks,
>> Christian.
>>
>>> Signed-off-by: Tommaso Merciai <tommaso.merciai@...rulasolutions.com>
>>> ---
>>>    drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
>>> index 58088c663125..efa3dc9b69fd 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
>>> @@ -1168,7 +1168,7 @@ static int amdgpu_cs_submit(struct amdgpu_cs_parser *p,
>>>    	struct amdgpu_bo_list_entry *e;
>>>    	struct amdgpu_job *job;
>>>    	uint64_t seq;
>>> -	int r;
>>> +	int r = 0;
>>>    	job = p->job;
>>>    	p->job = NULL;