linux-kernel - Re: [PATCH AUTOSEL 4.9 01/13] spi: spi-cadence: Fix SPI CS gets toggling sporadically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220920134832.GA19086@duo.ucw.cz>
Date:   Tue, 20 Sep 2022 15:48:32 +0200
From:   Pavel Machek <pavel@....cz>
To:     Sasha Levin <sashal@...nel.org>, Greg KH <greg@...ah.com>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@...inx.com>,
        Amit Kumar Mahapatra <amit.kumar-mahapatra@...inx.com>,
        Mark Brown <broonie@...nel.org>, linux-spi@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 4.9 01/13] spi: spi-cadence: Fix SPI CS gets
 toggling sporadically

Hi!

> From: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@...inx.com>
> 
> [ Upstream commit 21b511ddee09a78909035ec47a6a594349fe3296 ]
> 
> As part of unprepare_transfer_hardware, SPI controller will be disabled
> which will indirectly deassert the CS line. This will create a problem
> in some of the devices where message will be transferred with
> cs_change flag set(CS should not be deasserted).
> As per SPI controller implementation, if SPI controller is disabled then
> all output enables are inactive and all pins are set to input mode which
> means CS will go to default state high(deassert). This leads to an issue
> when core explicitly ask not to deassert the CS (cs_change = 1). This
> patch fix the above issue by checking the Slave select status bits from
> configuration register before disabling the SPI.

My records say this was already submitted to AUTOSEL at "Jun
27". There are more patches from that era that were reviewed in
AUTOSEL but not merged anywhere. Can you investigate?

Best regards,
								Pavel

a 4.9 01/13] spi: spi-cadence: Fix SPI CS gets toggling sporadic
a 4.9 02/13] spi: cadence: Detect transmit FIFO depth
n unused preparation 4.9 03/13] drm/vc4: crtc: Use an union to store the page f\
l
a 4.9 04/13] drivers/net/ethernet/neterion/vxge: Fix a use-af
n just a comment fix 4.9 05/13] video: fbdev: skeletonfb: Fix syntax errors in \
c
a just a printk tweak 4.9 06/13] video: fbdev: intelfb: Use aperture size from \
pc
a 4.9 07/13] video: fbdev: pxa3xx-gcu: Fix integer overflow i
n just a cleanup 4.9 08/13] video: fbdev: simplefb: Check before clk_put() n
a 4.9 09/13] mips: lantiq: falcon: Fix refcount leak bug in s
a 4.9 10/13] mips: lantiq: xway: Fix refcount leak bug in sys
n we still have reference to the name, it is not safe to put it 4.9 11/13] mips\
/pic32/pic32mzda: Fix refcount leak bugs
a 4.9 12/13] mips: lantiq: Add missing of_node_put() in irq.c

a 4.19 03/22] ALSA: usb-audio: US16x08: Move overflow check b
n unused preparation 4.19 05/22] drm/vc4: crtc: Move the BO handling out of com\
m
! do we have everything? 4.19 06/22] ALSA: x86: intel_hdmi_audio: enable pm_run\
time
! 4.19 07/22] hamradio: 6pack: fix array-index-out-of-bounds
a 4.19 13/22] arch: mips: generic: Add missing of_node_put()
a 4.19 14/22] mips: mti-malta: Fix refcount leak in malta-tim
a 4.19 15/22] mips: ralink: Fix refcount leak in of.c
a 4.19 20/22] drm/sun4i: Add DMA mask and segment size
! 4.19 21/22] drm/amdgpu: Adjust logic around GTT size (v3)

-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)