linux-kernel - Re: [PATCH v9 09/10] leds: flash: mt6370: Add MediaTek MT6370 flashlight support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Sep 2022 09:48:21 +0800
From:   ChiaEn Wu <peterwu.pub@...il.com>
To:     Han Jingoo <jingoohan1@...il.com>
Cc:     lee@...nel.org, Daniel Thompson <daniel.thompson@...aro.org>,
        Pavel Machek <pavel@....cz>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Sebastian Reichel <sre@...nel.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Helge Deller <deller@....de>, Mark Brown <broonie@...nel.org>,
        mazziesaccount@...il.com, andriy.shevchenko@...ux.intel.com,
        ChiaEn Wu <chiaen_wu@...htek.com>,
        Alice Chen <alice_chen@...htek.com>,
        ChiYuan Huang <cy_huang@...htek.com>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Linux LED Subsystem <linux-leds@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        "open list:FRAMEBUFFER LAYER" <linux-fbdev@...r.kernel.org>,
        szuni chen <szunichen@...il.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH v9 09/10] leds: flash: mt6370: Add MediaTek MT6370
 flashlight support

On Sun, Sep 18, 2022 at 3:22 AM Han Jingoo <jingoohan1@...il.com> wrote:
>
> On Mon, Aug 29, 2022 ChiaEn Wu <peterwu.pub@...il.com> wrote:

...

> > +#define MT6370_ITORCH_MIN_uA           25000
> > +#define MT6370_ITORCH_STEP_uA          12500
> > +#define MT6370_ITORCH_MAX_uA           400000
> > +#define MT6370_ITORCH_DOUBLE_MAX_uA    800000
> > +#define MT6370_ISTRB_MIN_uA            50000
> > +#define MT6370_ISTRB_STEP_uA           12500
> > +#define MT6370_ISTRB_MAX_uA            1500000
> > +#define MT6370_ISTRB_DOUBLE_MAX_uA     3000000
>
> Use upper letters as below:
>
> #define MT6370_ITORCH_MIN_UA           25000
> #define MT6370_ITORCH_STEP_UA          12500
> #define MT6370_ITORCH_MAX_UA           400000
> #define MT6370_ITORCH_DOUBLE_MAX_UA    800000
> #define MT6370_ISTRB_MIN_UA            50000
> #define MT6370_ISTRB_STEP_UA           12500
> #define MT6370_ISTRB_MAX_UA            1500000
> #define MT6370_ISTRB_DOUBLE_MAX_UA     3000000
>
>
> > +#define MT6370_STRBTO_MIN_US           64000
> > +#define MT6370_STRBTO_STEP_US          32000
> > +#define MT6370_STRBTO_MAX_US           2432000
> > +

Hi Jingoo,

This coding style is in accordance with Andy's opinion in this mail:
https://lore.kernel.org/linux-arm-kernel/CAHp75Vciq4M4kVrabNV9vTLLcd1vR=bMe8JLEdAF9MkRTpcB5g@mail.gmail.com/

And I will revise other parts in v12.
Thanks for your review!

--
Best Regards,
ChiaEn Wu