linux-kernel - [PATCH v5 12/13] Input: elants_i2c - Don't set wake_capable and wake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220921094736.v5.12.I031ffbe411e1bae20bf16a1876da5baf444c7928@changeid>
Date:   Wed, 21 Sep 2022 09:52:04 -0600
From:   Raul E Rangel <rrangel@...omium.org>
To:     linux-acpi@...r.kernel.org, linux-input@...r.kernel.org
Cc:     rafael@...nel.org, timvp@...gle.com,
        mika.westerberg@...ux.intel.com, andriy.shevchenko@...ux.intel.com,
        dmitry.torokhov@...il.com, jingle.wu@....com.tw,
        hdegoede@...hat.com, mario.limonciello@....com,
        linus.walleij@...aro.org, Raul E Rangel <rrangel@...omium.org>,
        Cai Huoqing <cai.huoqing@...ux.dev>,
        Guenter Roeck <groeck@...omium.org>,
        Johnny Chuang <johnny.chuang.emc@...il.com>,
        linux-kernel@...r.kernel.org
Subject: [PATCH v5 12/13] Input: elants_i2c - Don't set wake_capable and wake_irq

The i2c-core will now handle setting the wake_irq and wake capability
for DT and ACPI systems.

Signed-off-by: Raul E Rangel <rrangel@...omium.org>
---

(no changes since v1)

 drivers/input/touchscreen/elants_i2c.c | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c
index 80e16b533c452a..3500293bb1d8e1 100644
--- a/drivers/input/touchscreen/elants_i2c.c
+++ b/drivers/input/touchscreen/elants_i2c.c
@@ -1575,22 +1575,6 @@ static int elants_i2c_probe(struct i2c_client *client)
 		return error;
 	}
 
-	/*
-	 * Systems using device tree should set up wakeup via DTS,
-	 * the rest will configure device as wakeup source by default.
-	 */
-	if (!client->dev.of_node)
-		device_init_wakeup(&client->dev, true);
-
-	/*
-	 * The wake IRQ should be declared via device tree instead of assuming
-	 * the IRQ can wake the system. This is here for legacy reasons and
-	 * will be removed once the i2c-core supports querying ACPI for wake
-	 * capabilities.
-	 */
-	if (!client->dev.power.wakeirq)
-		dev_pm_set_wake_irq(&client->dev, client->irq);
-
 	error = devm_device_add_group(&client->dev, &elants_attribute_group);
 	if (error) {
 		dev_err(&client->dev, "failed to create sysfs attributes: %d\n",
-- 
2.37.3.968.ga6b4b080e4-goog