linux-kernel - Re: [PATCH bpf v5 0/3] Fix wrong cgroup attach flags being assigned to effective progs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 21 Sep 2022 18:30:16 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Pu Lehui <pulehui@...weicloud.com>
Cc:     martin.lau@...ux.dev, sdf@...gle.com, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org, ast@...nel.org, daniel@...earbox.net,
        andrii@...nel.org, quentin@...valent.com, song@...nel.org,
        yhs@...com, john.fastabend@...il.com, kpsingh@...nel.org,
        haoluo@...gle.com, jolsa@...nel.org, pulehui@...wei.com
Subject: Re: [PATCH bpf v5 0/3] Fix wrong cgroup attach flags being assigned to
 effective progs

Hello:

This series was applied to bpf/bpf.git (master)
by Martin KaFai Lau <martin.lau@...nel.org>:

On Wed, 21 Sep 2022 10:46:01 +0000 you wrote:
> From: Pu Lehui <pulehui@...wei.com>
> 
> When root-cgroup attach multi progs and sub-cgroup attach a
> override prog, bpftool will display incorrectly for the attach
> flags of the sub-cgroup’s effective progs:
> 
> $ bpftool cgroup tree /sys/fs/cgroup effective
> CgroupPath
> ID       AttachType      AttachFlags     Name
> /sys/fs/cgroup
> 6        cgroup_sysctl   multi           sysctl_tcp_mem
> 13       cgroup_sysctl   multi           sysctl_tcp_mem
> /sys/fs/cgroup/cg1
> 20       cgroup_sysctl   override        sysctl_tcp_mem
> 6        cgroup_sysctl   override        sysctl_tcp_mem <- wrong
> 13       cgroup_sysctl   override        sysctl_tcp_mem <- wrong
> /sys/fs/cgroup/cg1/cg2
> 20       cgroup_sysctl                   sysctl_tcp_mem
> 6        cgroup_sysctl                   sysctl_tcp_mem
> 13       cgroup_sysctl                   sysctl_tcp_mem
> 
> [...]

Here is the summary with links:
  - [bpf,v5,1/3] bpf, cgroup: Reject prog_attach_flags array when effective query
    https://git.kernel.org/bpf/bpf/c/0e426a3ae030
  - [bpf,v5,2/3] bpftool: Fix wrong cgroup attach flags being assigned to effective progs
    https://git.kernel.org/bpf/bpf/c/bdcee1b0b083
  - [bpf,v5,3/3] selftests/bpf: Adapt cgroup effective query uapi change
    https://git.kernel.org/bpf/bpf/c/d2aa993b7d9d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html