linux-kernel - Re: [RFC PATCH 3/5] dt-bindings: iio: Add KX022A accelerometer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Sep 2022 19:30:19 +0000
From:   "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Matti Vaittinen <mazziesaccount@...il.com>
CC:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Nikita Yushchenko <nikita.yoush@...entembedded.com>,
        Cosmin Tanislav <demonsingur@...il.com>,
        Jagath Jog J <jagathjog1996@...il.com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 3/5] dt-bindings: iio: Add KX022A accelerometer

Hi dee Ho Krzysztof,

Thanks for looking through this!

On 9/21/22 22:11, Krzysztof Kozlowski wrote:
> On 21/09/2022 13:45, Matti Vaittinen wrote:
>> KX022A is a 3-axis Accelerometer from ROHM/Kionix. The senor features
>> include variable ODRs, I2C and SPI control, FIFO/LIFO with watermark IRQ,
>> +
>> +maintainers:
>> +  - Matti Vaittinen <matti.vaittinen@...rohmeurope.com>

My own comment - switch the email to the gmail-one. Company mail is 
unreliable at best..

>> +
>> +description: |
>> +  KX022A is a 3-axis accelerometer supporting +/- 2G, 4G, 8G and 16G ranges,
>> +  output data-rates from 0.78Hz to 1600Hz and a hardware-fifo buffering.
>> +  KX022A can be accessed either via I2C or SPI.
>> +
>> +properties:
>> +  compatible: kionix,kx022a
> 
> Missing const. I wonder how did it pass testing...

I originally had
oneOf:
  items const ...
construct here as I had separate compatibles for *-spi and *-i2c. I am 
unsure if I remembered to run the tests after dropping the extra 
compatibles :| - Sorry! I'll fix this.

>> +  io_vdd-supply: true
> 
> No underscores, so io-vdd-supply

The rationale behind the underscore is that the data-sheet uses terms 
vdd and vdd_io (with underscore). I wanted to match the supply name to 
what is used in the data-sheet. Not a big thing but I'd rather kept if 
same as the data-sheet if the requirement of "no-underscores" is not 
"hard". (If it is, then I'll drop the underscore).

Other than that I agree with all of your points. Thanks for checking 
this! Appreciated!

Yours,
	--Matti

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~