linux-kernel - Re: [PATCH v5 1/8] i2c: i2c-mlxbf.c: Fix frequency calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yytpp4c9Brcnx5s3@shikoro>
Date:   Wed, 21 Sep 2022 21:44:39 +0200
From:   Wolfram Sang <wsa+renesas@...g-engineering.com>
To:     Asmaa Mnebhi <asmaa@...dia.com>
Cc:     linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        Khalil Blaiech <kblaiech@...dia.com>
Subject: Re: [PATCH v5 1/8] i2c: i2c-mlxbf.c: Fix frequency calculation

On Tue, Sep 20, 2022 at 01:47:29PM -0400, Asmaa Mnebhi wrote:
> The i2c-mlxbf.c driver is currently broken because there is a bug
> in the calculation of the frequency. core_f, core_r and core_od
> are components read from hardware registers and are used to
> compute the frequency used to compute different timing parameters.
> The shifting mechanism used to get core_f, core_r and core_od is
> wrong. Use FIELD_GET to mask and shift the bitfields properly.
> 
> Fixes: b5b5b32081cd206b (i2c: mlxbf: I2C SMBus driver for Mellanox BlueField SoC)
> Reviewed-by: Khalil Blaiech <kblaiech@...dia.com>
> Signed-off-by: Asmaa Mnebhi <asmaa@...dia.com>

Applied to for-current, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)