[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YytvxVs7g5vx8AAM@shikoro>
Date: Wed, 21 Sep 2022 22:10:45 +0200
From: Wolfram Sang <wsa@...nel.org>
To: Raul E Rangel <rrangel@...omium.org>
Cc: linux-acpi@...r.kernel.org, linux-input@...r.kernel.org,
rafael@...nel.org, timvp@...gle.com,
mika.westerberg@...ux.intel.com, andriy.shevchenko@...ux.intel.com,
dmitry.torokhov@...il.com, jingle.wu@....com.tw,
hdegoede@...hat.com, mario.limonciello@....com,
linus.walleij@...aro.org, linux-i2c@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 07/13] i2c: acpi: Use ACPI wake capability bit to set
wake_irq
On Wed, Sep 21, 2022 at 09:51:59AM -0600, Raul E Rangel wrote:
> Device tree already has a mechanism to pass the wake_irq. It does this
> by looking for the wakeup-source property and setting the
> I2C_CLIENT_WAKE flag. This CL adds the ACPI equivalent. It uses the
> ACPI interrupt wake flag to determine if the interrupt can be used to
> wake the system. Previously the i2c drivers had to make assumptions and
> blindly enable the wake IRQ. This can cause spurious wake events. e.g.,
> If there is a device with an Active Low interrupt and the device gets
> powered off while suspending, the interrupt line will go low since it's
> no longer powered and wakes the system. For this reason we should
> respect the board designers wishes and honor the wake bit defined on the
> interrupt.
>
> Signed-off-by: Raul E Rangel <rrangel@...omium.org>
> Reviewed-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>
Acked-by: Wolfram Sang <wsa@...nel.org>
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists