linux-kernel - Re: [PATCH v7 4/9] dt-bindings: qcom-qce: Add new SoC compatible strings for qcom-qce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05a1447e-51b1-cd6b-36bc-98f011e786e0@linaro.org>
Date:   Wed, 21 Sep 2022 11:30:46 +0530
From:   Bhupesh Sharma <bhupesh.sharma@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        linux-crypto@...r.kernel.org, devicetree@...r.kernel.org
Cc:     agross@...nel.org, herbert@...dor.apana.org.au,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        linux-arm-msm@...r.kernel.org, thara.gopinath@...il.com,
        robh@...nel.org, andersson@...nel.org, bhupesh.linux@...il.com,
        davem@...emloft.net, Jordan Crouse <jorcrous@...zon.com>
Subject: Re: [PATCH v7 4/9] dt-bindings: qcom-qce: Add new SoC compatible
 strings for qcom-qce


On 9/20/22 8:40 PM, Krzysztof Kozlowski wrote:
> On 20/09/2022 13:40, Bhupesh Sharma wrote:
>> Newer Qualcomm chips support newer versions of the qce crypto IP, so add
>> soc specific compatible strings for qcom-qce instead of using crypto
>> IP version specific ones.
>>
>> Keep the old strings for backward-compatibility, but mark them as
>> deprecated.
>>
>> Cc: Bjorn Andersson <andersson@...nel.org>
>> Reviewed-by: Rob Herring <robh@...nel.org>
>> Tested-by: Jordan Crouse <jorcrous@...zon.com>
>> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@...aro.org>
>> ---
>>   .../devicetree/bindings/crypto/qcom-qce.yaml         | 12 ++++++++++--
>>   1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
>> index 4e00e7925fed..aa2f676f5382 100644
>> --- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
>> +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
>> @@ -15,7 +15,15 @@ description:
>>   
>>   properties:
>>     compatible:
>> -    const: qcom,crypto-v5.1
>> +    enum:
>> +      - qcom,crypto-v5.1 # Deprecated. Kept only for backward compatibility
> 
> No changes since v6.

Right. v7 is just to propose the new subset of patchsets and ordering 
(since we changed it from v5 - which was a single patchset) and get some 
early feedback and comments and get to know if the respective 
maintainers are fine with the patch ordering, cc-list etc.

I will surely include your comments in v8.

Thanks,
Bhupesh