linux-kernel - Re: [PATCH v9,2/7] dt-bindings: thermal: Add dt-binding document for LVTS thermal controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Sep 2022 08:22:07 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Balsam CHIHI <bchihi@...libre.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
Cc:     rafael@...nel.org, rui.zhang@...el.com, daniel.lezcano@...aro.org,
        amitk@...nel.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, khilman@...libre.com,
        mka@...omium.org, robh+dt@...nel.org, krzk+dt@...nel.org,
        matthias.bgg@...il.com, p.zabel@...gutronix.de,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, james.lo@...iatek.com,
        fan.chen@...iatek.com, louis.yu@...iatek.com,
        rex-bc.chen@...iatek.com, abailon@...libre.com
Subject: Re: [PATCH v9,2/7] dt-bindings: thermal: Add dt-binding document for
 LVTS thermal controllers

On 14/09/2022 16:01, Balsam CHIHI wrote:
> Hi Angelo,
> 
> I've got the following errors after implementing these changes :
> [...]
>   nvmem-cells:
>     minItems: 1
>     description: Calibration eFuse data for LVTS
> 
>   nvmem-cell-names:
>     minItems: 1
>     items:
>       pattern: 'lvts-calib-data[0-9]+$'
> 
>   "#thermal-sensor-cells":
>     const: 1
> 
> allOf:
>   - $ref: thermal-sensor.yaml#
> 
>   - if:
>       properties:
>         compatible:
>           contains:
>             enum:
>               - mediatek,mt8192-lvts-ap
>               - mediatek,mt8192-lvts-mcu
>     then:
>       properties:
>         nvmem-cells:
>           maxItems: 1
> 
>         nvmem-cell-names:
>           maxItems: 1
> 
>   - if:
>       properties:
>         compatible:
>           contains:
>             enum:
>               - mediatek,mt8195-lvts-ap
>               - mediatek,mt8195-lvts-mcu
>     then:
>       properties:
>         nvmem-cells:
>           maxItems: 2
> 
>         nvmem-cell-names:
>           maxItems: 2
> [...]
> 
> $ make DT_CHECKER_FLAGS=-m dt_binding_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
>   LINT    Documentation/devicetree/bindings
>   CHKDT   Documentation/devicetree/bindings/processed-schema.json
> /home/balsam/src/linux-mtk-lvts-newThermalOF/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml:
> properties:nvmem-cell-names:items: {'pattern':
> 'lvts-calib-data[0-9]+$'} is not of type 'array'
> from schema $id: http://devicetree.org/meta-schemas/string-array.yaml#
>   SCHEMA  Documentation/devicetree/bindings/processed-schema.json
> /home/balsam/src/linux-mtk-lvts-newThermalOF/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml:
> ignoring, error in schema: properties: nvmem-cell-names: items
>   DTEX    Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.example.dts
>   DTC     Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.example.dtb
>   CHECK   Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.example.dtb
> Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.example.dtb:0:0:
> /example-0/soc/thermal-sensor@...0b000: failed to match any schema
> with compatible: ['mediatek,mt8192-lvts-ap']
> 
> am I missing something?

Maybe maxItems: 2 in top-level property?


Best regards,
Krzysztof