linux-kernel - Re: [PATCH] padata: fix lockdep warning in padata serialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220921073616.GZ2950045@gauss3.secunet.de>
Date:   Wed, 21 Sep 2022 09:36:16 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Daniel Jordan <daniel.m.jordan@...cle.com>
CC:     <eadavis@...a.com>, <linux-crypto@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <syzbot+bc05445bc14148d51915@...kaller.appspotmail.com>,
        <syzkaller-bugs@...glegroups.com>
Subject: Re: [PATCH] padata: fix lockdep warning in padata serialization

On Tue, Sep 20, 2022 at 10:10:57AM -0400, Daniel Jordan wrote:
> Hi Steffen,
> 
> On Tue, Sep 20, 2022 at 07:54:43AM +0200, Steffen Klassert wrote:
> > On Mon, Sep 19, 2022 at 09:47:11PM -0400, Daniel Jordan wrote:
> > > On Tue, Sep 20, 2022 at 08:39:08AM +0800, eadavis@...a.com wrote:
> > > > From: Edward Adam Davis <eadavis@...a.com>
> > > > 
> > > > On Mon, 19 Sep 2022 11:12:48 -0400, Daniel Jordan wrote:
> > > > > Hi Edward,
> > > > > 
> > > > > On Mon, Sep 19, 2022 at 09:05:55AM +0800, eadavis@...a.com wrote:
> > > > > > From: Edward Adam Davis <eadavis@...a.com>
> > > > > > 
> > > > > > Parallelized object serialization uses spin_unlock for unlocking a spin lock
> > > > > > that was previously locked with spin_lock.
> > > > > 
> > > > > There's nothing unusual about that, though?
> > > > > 
> > > > > > This caused the following lockdep warning about an inconsistent lock
> > > > > > state:
> > > > > > 
> > > > > >         inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage.
> > > > > 
> > > > > Neither HARDIRQ-ON-W nor IN-HARDIRQ-W appear in the syzbot report, did
> > > > > you mean SOFTIRQ-ON-W and IN-SOFTIRQ-W?
> > > > Yes, I want say: inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage.
> > > > > 
> > > > > > We must use spin_lock_irqsave, because it is possible to trigger tipc 
> > > > > > from an irq handler.
> > > > > 
> > > > > A softirq handler, not a hardirq handler.  I'd suggest using
> > > > > spin_lock_bh() instead of _irqsave in your patch.
> > > > I think _irqsave better than _bh, it can save the irq context, but _bh not, 
> > > > and in tipc call trace contain SOFTIRQ-ON-W and IN-SOFTIRQ-W.
> > > 
> > > _irqsave saving the context is about handling nested hardirq disables.
> > > It's not needed here since we don't need to care about disabling
> > > hardirq.
> > > 
> > > _bh is for disabling softirq, a different context from hardirq.  We want
> > > _bh here since the deadlock happens when a CPU takes the lock in both
> > > task and softirq context.  padata uses _bh lock variants because it can
> > > be called in softirq context but not hardirq.  Let's be consistent and
> > > do it in this case too.
> > 
> > padata_do_serial is called with BHs off, so using spin_lock_bh should not
> > fix anything here. I guess the problem is that we call padata_find_next
> > after we enabled the BHs in padata_reorder.
> 
> Yeah, padata_do_serial can be called with BHs off, like in the tipc
> stack, but there are also cases where BHs can be on, like lockdep said
> here:

padata_do_serial was designed to run with BHs off, it is a bug if it
runs with BHs on. But I don't see a case where this can happen. The
only user of padata_do_serial is pcrypt in its serialization callbacks
(pcrypt_aead_enc, pcrypt_aead_dec) and the async crypto callback
pcrypt_aead_done. pcrypt_aead_enc and pcrypt_aead_dec are issued via
the padata_serial_worker with the padata->serial call. BHs are
off here. The crypto callback also runs with BHs off.

What do I miss here?