linux-kernel - Re: [PATCH net-next 1/2] udp: Refactor udp_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220920174052.47d9858b@kernel.org>
Date:   Tue, 20 Sep 2022 17:40:52 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Peilin Ye <yepeilin.cs@...il.com>
Cc:     Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Peilin Ye <peilin.ye@...edance.com>,
        Cong Wang <cong.wang@...edance.com>,
        Kuniyuki Iwashima <kuniyu@...zon.com>,
        Alexei Starovoitov <ast@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] udp: Refactor udp_read_skb()

On Tue, 20 Sep 2022 17:38:59 -0700 Jakub Kicinski wrote:
> On Wed, 14 Sep 2022 01:15:30 -0700 Peilin Ye wrote:
> > Delete the unnecessary while loop in udp_read_skb() for readability.
> > Additionally, since recv_actor() cannot return a value greater than
> > skb->len (see sk_psock_verdict_recv()), remove the redundant check.  
> 
> These don't apply cleanly, please rebase?

Ah, it's the WARN_ON_ONCE() change. In that case please resend after
net is merged into net-next (Thu evening).