linux-kernel - Re: [PATCH v4 2/4] mtd: always initialize 'stats' in struct mtd_oob

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220921084111.733303-1-miquel.raynal@bootlin.com>
Date:   Wed, 21 Sep 2022 10:41:11 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Michał Kępień <kernel@...pniu.pl>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>
Cc:     Boris Brezillon <boris.brezillon@...labora.com>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/4] mtd: always initialize 'stats' in struct mtd_oob_ops

On Wed, 2022-06-29 at 12:57:35 UTC, =?utf-8?b?TWljaGHFgiBLxJlwaWXFhA==?= wrote:
> As the 'stats' field in struct mtd_oob_ops is used in conditional
> expressions, ensure it is always zero-initialized in all such structures
> to prevent random stack garbage from being interpreted as a pointer.
> 
> Strictly speaking, this problem currently only needs to be fixed for
> struct mtd_oob_ops structures subsequently passed to mtd_read_oob().
> However, this commit goes a step further and makes all instances of
> struct mtd_oob_ops in the tree zero-initialized, in hope of preventing
> future problems, e.g. if struct mtd_req_stats gets extended with write
> statistics at some point.
> 
> Signed-off-by: Michał Kępień <kernel@...pniu.pl>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel