linux-kernel - Re: [PATCH] x86/mm: disable instrumentations of mm/pgprot.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YyrSgXltQr5XrnSN@x1-carbon>
Date:   Wed, 21 Sep 2022 08:59:46 +0000
From:   Niklas Cassel <Niklas.Cassel@....com>
To:     "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>
CC:     "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Andy Lutomirski <luto@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>,
        Anshuman Khandual <anshuman.khandual@....com>,
        Naohiro Aota <Naohiro.Aota@....com>
Subject: Re: [PATCH] x86/mm: disable instrumentations of mm/pgprot.c

On Wed, Aug 24, 2022 at 05:47:26PM +0900, Naohiro Aota wrote:
> The commit 4867fbbdd6b3 ("x86/mm: move protection_map[] inside the
> platform") moved accesses to protection_map[] from mem_encrypt_amd.c to
> pgprot.c. As a result, the accesses are now targets of KASAN (and other
> instrumentations), leading to the crash during the boot process.
> 
> Disable the instrumentations for pgprot.c like commit 67bb8e999e0a
> ("x86/mm: Disable various instrumentations of mm/mem_encrypt.c and
> mm/tlb.c").
> 
> Before this patch, my AMD machine cannot boot since v6.0-rc1 with KASAN
> enabled, without anything printed. After the change, it successfully boots
> up.
> 
> Cc: Anshuman Khandual <anshuman.khandual@....com>
> Signed-off-by: Naohiro Aota <naohiro.aota@....com>
> ---

Hello Andrew,

I see that this patch is in linux-next, but not in Linus's tree.

Since this fixes something introduced in v6.0-rc1, I think this
ought to go into v6.0 before it is released.


Kind regards,
Niklas