linux-kernel - Re: [PATCH RFC 3/6] scsi: core: Add scsi_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d271ce3-b289-4ecb-3555-c31dfa6091de@huawei.com>
Date:   Wed, 21 Sep 2022 10:17:48 +0100
From:   John Garry <john.garry@...wei.com>
To:     Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>, <hare@...e.de>,
        <hch@....de>
CC:     <linux-ide@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-scsi@...r.kernel.org>, <brking@...ibm.com>
Subject: Re: [PATCH RFC 3/6] scsi: core: Add scsi_get_dev()

On 20/09/2022 22:58, Damien Le Moal wrote:
>> +extern struct scsi_device *scsi_get_dev(struct device *parent, int 
>> channel, uint id, u64 lun);
> 
> You should not need extern here, and long line...
> 
>> +
>>   /*
>> +
> 
> white line change.
> 
>>    * DIF defines the exchange of protection information between
>>    * initiator and SBC block device. 

ok, I'll tidy them.

Thanks,
John