linux-kernel - Re: [PATCH] lib/vdso: use "grep -E" instead of "egrep"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad42d19d-959c-61b4-8581-02ce0990c23f@arm.com>
Date:   Wed, 21 Sep 2022 10:44:48 +0100
From:   Vincenzo Frascino <vincenzo.frascino@....com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Cc:     Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] lib/vdso: use "grep -E" instead of "egrep"

On 9/20/22 18:06, Greg Kroah-Hartman wrote:
> The latest version of grep claims the egrep is now obsolete so the build
> now contains warnings that look like:
> 	egrep: warning: egrep is obsolescent; using grep -E
> fix this up by moving the vdso Makefile to use "grep -E" instead.
> 
> Cc: Andy Lutomirski <luto@...nel.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Vincenzo Frascino <vincenzo.frascino@....com>

Reviewed-by: Vincenzo Frascino <vincenzo.frascino@....com>

> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  lib/vdso/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/vdso/Makefile b/lib/vdso/Makefile
> index c415a685d61b..e814061d6aa0 100644
> --- a/lib/vdso/Makefile
> +++ b/lib/vdso/Makefile
> @@ -17,6 +17,6 @@ $(error ARCH_REL_TYPE_ABS is not set)
>  endif
>  
>  quiet_cmd_vdso_check = VDSOCHK $@
> -      cmd_vdso_check = if $(OBJDUMP) -R $@ | egrep -h "$(ARCH_REL_TYPE_ABS)"; \
> +      cmd_vdso_check = if $(OBJDUMP) -R $@ | grep -E -h "$(ARCH_REL_TYPE_ABS)"; \
>  		       then (echo >&2 "$@: dynamic relocations are not supported"; \
>  			     rm -f $@; /bin/false); fi

-- 
Regards,
Vincenzo