linux-kernel - Re: [PATCH v2 3/3] thermal: loongson2: add thermal management support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Sep 2022 17:59:17 +0800
From:   kernel test robot <lkp@...el.com>
To:     Yinbo Zhu <zhuyinbo@...ngson.cn>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        zhanghongchen <zhanghongchen@...ngson.cn>,
        Yinbo Zhu <zhuyinbo@...ngson.cn>
Subject: Re: [PATCH v2 3/3] thermal: loongson2: add thermal management support

Hi Yinbo,

I love your patch! Perhaps something to improve:

[auto build test WARNING on rafael-pm/thermal]
[also build test WARNING on linus/master v6.0-rc6 next-20220920]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Yinbo-Zhu/MAINTAINERS-add-maintainer-for-thermal-driver-for-loongson2-SoCs/20220921-095737
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal
config: i386-randconfig-a002
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/c21dcaa77e2e7514efdb4c97c805b14c9a05ec35
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Yinbo-Zhu/MAINTAINERS-add-maintainer-for-thermal-driver-for-loongson2-SoCs/20220921-095737
        git checkout c21dcaa77e2e7514efdb4c97c805b14c9a05ec35
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/thermal/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/thermal/loongson2_thermal.c:183:5: warning: no previous prototype for function 'loongson2_thermal_remove' [-Wmissing-prototypes]
   int loongson2_thermal_remove(struct platform_device *pdev)
       ^
   drivers/thermal/loongson2_thermal.c:183:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int loongson2_thermal_remove(struct platform_device *pdev)
   ^
   static 
   1 warning generated.


vim +/loongson2_thermal_remove +183 drivers/thermal/loongson2_thermal.c

   182	
 > 183	int loongson2_thermal_remove(struct platform_device *pdev)
   184	{
   185		struct loongson2_thermal_data *data = platform_get_drvdata(pdev);
   186		int reg_off = data->id * 2;
   187	
   188		/* disable interrupt */
   189		writew(0, data->regs + LOONGSON2_TSENSOR_CTRL_LO + reg_off);
   190		writew(0, data->regs + LOONGSON2_TSENSOR_CTRL_HI + reg_off);
   191	
   192		return 0;
   193	}
   194	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (164080 bytes)