linux-kernel - RE: [PATCH] proc: report open files as size in stat() for /proc/pid/fd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6aa0151527a4ee39ae85dfd34e71864@AcuMS.aculab.com>
Date:   Wed, 21 Sep 2022 10:21:24 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Ivan Babrou' <ivan@...udflare.com>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-team@...udflare.com" <kernel-team@...udflare.com>,
        Alexey Dobriyan <adobriyan@...il.com>,
        Al Viro <viro@...iv.linux.org.uk>,
        Theodore Ts'o <tytso@....edu>,
        Jonathan Corbet <corbet@....net>,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Hildenbrand <david@...hat.com>,
        "Johannes Weiner" <hannes@...xchg.org>,
        Christoph Anton Mitterer <mail@...istoph.anton.mitterer.name>,
        Vincent Whitchurch <vincent.whitchurch@...s.com>,
        Mike Rapoport <rppt@...nel.org>,
        Yang Shi <shy828301@...il.com>,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        "Kalesh Singh" <kaleshsingh@...gle.com>
Subject: RE: [PATCH] proc: report open files as size in stat() for
 /proc/pid/fd

From: Ivan Babrou
> Sent: 20 September 2022 20:06
...
> 
> +static int proc_readfd_count(struct inode *inode)
> +{
> +	struct task_struct *p = get_proc_task(inode);
> +	struct fdtable *fdt;
> +	unsigned int i, size, open_fds = 0;
> +
> +	if (!p)
> +		return -ENOENT;
> +
> +	if (p->files) {
> +		fdt = files_fdtable(p->files);
> +		size = fdt->max_fds;
> +
> +		for (i = size / BITS_PER_LONG; i > 0;)
> +			open_fds += hweight64(fdt->open_fds[--i]);
> +	}
> +
> +	return open_fds;
> +}
> +

Doesn't that need (at least) rcu protection?
There might also be issues reading p->files twice.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)