linux-kernel - Re: [PATCH v1] mm/vmscan: check the return value of migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5b74c435-6dec-4346-e237-ad36bfcb9789@linux.alibaba.com>
Date:   Wed, 21 Sep 2022 18:42:24 +0800
From:   Baolin Wang <baolin.wang@...ux.alibaba.com>
To:     Li Zhong <floridsleeves@...il.com>, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org
Cc:     akpm@...ux-foundation.org
Subject: Re: [PATCH v1] mm/vmscan: check the return value of migrate_pages()

Hi,

On 9/17/2022 10:12 AM, Li Zhong wrote:
> Check the return value of migrate_pages() to check error exeuction.
> 
> Signed-off-by: Li Zhong <floridsleeves@...il.com>
> ---
>   mm/vmscan.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index b2b1431352dc..50aaaa9377e2 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -1547,6 +1547,7 @@ static unsigned int demote_page_list(struct list_head *demote_pages,
>   {
>   	int target_nid = next_demotion_node(pgdat->node_id);
>   	unsigned int nr_succeeded;
> +	int ret;
>   
>   	if (list_empty(demote_pages))
>   		return 0;
> @@ -1555,10 +1556,13 @@ static unsigned int demote_page_list(struct list_head *demote_pages,
>   		return 0;
>   
>   	/* Demotion ignores all cpuset and mempolicy settings */
> -	migrate_pages(demote_pages, alloc_demote_page, NULL,
> +	ret = migrate_pages(demote_pages, alloc_demote_page, NULL,
>   			    target_nid, MIGRATE_ASYNC, MR_DEMOTION,
>   			    &nr_succeeded);
>   
> +	if (ret)
> +		putback_movable_pages(&pagelist);

You can not just put them back into the original lru list, instead the 
caller has handled the failed-to-demote pages, which will try to reclaim 
them.

In addition, the code cannot even be built successfully.