linux-kernel - Re: [PATCH v1 4/4] arm: dts: imx7-colibri: remove spurious debounce property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 21 Sep 2022 14:28:27 +0200
From:   Francesco Dolcini <francesco.dolcini@...adex.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Francesco Dolcini <francesco.dolcini@...adex.com>,
        Marcel Ziswiler <marcel@...wiler.com>,
        linux-arm-kernel@...ts.infradead.org,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Fabio Estevam <festevam@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Rob Herring <robh+dt@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 4/4] arm: dts: imx7-colibri: remove spurious debounce
 property

On Wed, Sep 21, 2022 at 02:23:17PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Sep 21, 2022 at 02:15:05PM +0200, Francesco Dolcini wrote:
> > +Greg, to get an opinion on the fixes tag.
> > 
> > On Tue, Sep 20, 2022 at 11:22:27AM +0200, Marcel Ziswiler wrote:
> > > From: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> > > 
> > > Remove spurious debounce property from linux,extcon-usb-gpio.
> > > 
> > > Note that debouncing is hard-coded to 20 ms (USB_GPIO_DEBOUNCE_MS
> > > define).
> > > 
> > > Fixes: 0ef1969ea569 ("ARM: dts: imx7-colibri: move aliases, chosen, extcon and gpio-keys")
> > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> > 
> > Hello all,
> > we did have some (internal) discussion if this patch should have the
> > fixes tag or not.
> > 
> > I do personally think it should not have it and should not be backported
> > to stable tree, since this is not fixing a real bug, it's just a
> > cleanup.
> 
> If it's not a real bug, why would you have a Fixes: tag on the commit?
> 
> > On the other hand the original patch was not correct, and this change is
> > making it right.
> 
> Ah, so it is a bugfix.

The DTS file should not contain this unknown property, however having
this property present does not change the behavior of the code.

It's more like an unused variable kind of error that could trigger a
warning in the compiler.

Francesco