linux-kernel - Re: [PATCH linux-next] mmc: rtsx_usb_sdmmc: Remove the unneeded result variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 21 Sep 2022 14:49:30 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     cgel.zte@...il.com
Cc:     linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
        ye xingchen <ye.xingchen@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] mmc: rtsx_usb_sdmmc: Remove the unneeded
 result variable

On Tue, 20 Sept 2022 at 08:46, <cgel.zte@...il.com> wrote:
>
> From: ye xingchen <ye.xingchen@....com.cn>
>
> Return the value rtsx_usb_send_cmd() directly instead of storing it in
> another redundant variable.
>
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/rtsx_usb_sdmmc.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c b/drivers/mmc/host/rtsx_usb_sdmmc.c
> index 5fe4528e296e..5798aee06653 100644
> --- a/drivers/mmc/host/rtsx_usb_sdmmc.c
> +++ b/drivers/mmc/host/rtsx_usb_sdmmc.c
> @@ -1042,7 +1042,6 @@ static int sd_set_timing(struct rtsx_usb_sdmmc *host,
>                 unsigned char timing, bool *ddr_mode)
>  {
>         struct rtsx_ucr *ucr = host->ucr;
> -       int err;
>
>         *ddr_mode = false;
>
> @@ -1097,9 +1096,7 @@ static int sd_set_timing(struct rtsx_usb_sdmmc *host,
>                 break;
>         }
>
> -       err = rtsx_usb_send_cmd(ucr, MODE_C, 100);
> -
> -       return err;
> +       return rtsx_usb_send_cmd(ucr, MODE_C, 100);
>  }
>
>  static void sdmmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
> --
> 2.25.1