linux-kernel - Re: [PATCH v3 1/1] serial: 8250: Toggle IER bits on only after irq has been set up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yysm9ALLsXk3oYRt@smile.fi.intel.com>
Date:   Wed, 21 Sep 2022 18:00:04 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc:     Lennert Buytenhek <buytenh@...tstofly.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Alex Williamson <alex.williamson@...com>,
        Aristeu Sergio Rozanski Filho <aris@...hedrallabs.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-serial <linux-serial@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Lennert Buytenhek <buytenh@...sta.com>
Subject: Re: [PATCH v3 1/1] serial: 8250: Toggle IER bits on only after irq
 has been set up

On Wed, Sep 21, 2022 at 04:20:50PM +0300, Ilpo Järvinen wrote:
> On Mon, 19 Sep 2022, Ilpo Järvinen wrote:

...

> > -	retval = up->ops->setup_irq(up);
> > -	if (retval)
> > -		goto out;
> > +	univ8250_setup_timer(up);

> Please scratch this patch. It seems to create a circular dependency issue
> with allmodconfig. I'll send v4 once the problem is sorted out.

In accordance with what you told me privately, I think you will need yet
another ops, i.e. ->setup_timer().

-- 
With Best Regards,
Andy Shevchenko