lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 Sep 2022 17:06:49 +0200 From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> To: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>, Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, Banajit Goswami <bgoswami@...cinc.com>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Vinod Koul <vkoul@...nel.org>, alsa-devel@...a-project.org, linux-kernel@...r.kernel.org Cc: stable@...r.kernel.org Subject: Re: [PATCH 1/2] ASoC: wcd9335: fix order of Slimbus unprepare/disable On 21/09/2022 17:05, Pierre-Louis Bossart wrote: >> diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c >> index 06c6adbe5920..d2548fdf9ae5 100644 >> --- a/sound/soc/codecs/wcd9335.c >> +++ b/sound/soc/codecs/wcd9335.c >> @@ -1972,8 +1972,8 @@ static int wcd9335_trigger(struct snd_pcm_substream *substream, int cmd, >> case SNDRV_PCM_TRIGGER_STOP: >> case SNDRV_PCM_TRIGGER_SUSPEND: >> case SNDRV_PCM_TRIGGER_PAUSE_PUSH: >> - slim_stream_unprepare(dai_data->sruntime); >> slim_stream_disable(dai_data->sruntime); >> + slim_stream_unprepare(dai_data->sruntime); > > This looks logical but different from what the kernel doc says: > > /** > * slim_stream_disable() - Disable a SLIMbus Stream > * > * @stream: instance of slim stream runtime to disable > * > * This API will disable all the ports and channels associated with > * SLIMbus stream > * > * Return: zero on success and error code on failure. From ASoC DPCM > framework, > * this state is linked to trigger() pause operation. > */ > > /** > * slim_stream_unprepare() - Un-prepare a SLIMbus Stream > * > * @stream: instance of slim stream runtime to unprepare > * > * This API will un allocate all the ports and channels associated with > * SLIMbus stream You mean this piece of doc? Indeed looks inaccurate. I'll update it. Best regards, Krzysztof
Powered by blists - more mailing lists