linux-kernel - Re: [PATCH v4 4/4] input: touchscreen: elants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=WEa=+Gp5o1YjLnLrYQ7uMPa3QLy1R6m6Cygo0bbugYcg@mail.gmail.com>
Date:   Thu, 22 Sep 2022 09:35:01 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Yunlong Jia <ecs.beijing2022@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Yunlong Jia <yunlong.jia@....com.tw>,
        Henry Sun <henrysun@...gle.com>,
        Bob Moragues <moragues@...omium.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Guenter Roeck <groeck@...omium.org>,
        Johnny Chuang <johnny.chuang.emc@...il.com>,
        "open list:HID CORE LAYER" <linux-input@...r.kernel.org>
Subject: Re: [PATCH v4 4/4] input: touchscreen: elants_i2c: Add eth3915n
 touchscreen chip

Hi,

On Thu, Sep 22, 2022 at 3:23 AM Yunlong Jia <ecs.beijing2022@...il.com> wrote:
>
> The ekth3915 and ekth3500 are almost the same.
>
> Signed-off-by: Yunlong Jia <ecs.beijing2022@...il.com>
> Reviewed-by: Douglas Anderson <dianders@...omium.org>

You shouldn't have added my Reviewed-by here. I haven't seen this patch before.

Also: you should drop this patch. The way we've specified it in the
bindings you can rely on the "fallback" compatible string for the 3500
to handle things.