linux-kernel - Re: [PATCH v5 4/6] iommu: Regulate EINVAL in ->attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Sep 2022 14:25:46 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Nicolin Chen <nicolinc@...dia.com>
Cc:     joro@...tes.org, will@...nel.org, robin.murphy@....com,
        dwmw2@...radead.org, baolu.lu@...ux.intel.com,
        yong.wu@...iatek.com, matthias.bgg@...il.com, kevin.tian@...el.com,
        iommu@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v5 4/6] iommu: Regulate EINVAL in ->attach_dev callback
 functions

On Thu, Sep 22, 2022 at 01:54:20AM -0700, Nicolin Chen wrote:
> Following the new rules in include/linux/iommu.h kdocs, EINVAL now can be
> used to indicate that domain and device are incompatible by a caller that
> treats it as a soft failure and tries attaching to another domain.
> 
> On the other hand, there are ->attach_dev callback functions returning it
> for obvious device-specific errors. They will result in some inefficiency
> in the caller handling routine.
> 
> Update these places to corresponding errnos following the new rules.
> 
> Reviewed-by: Jean-Philippe Brucker <jean-philippe@...aro.org>
> Reviewed-by: Lu Baolu <baolu.lu@...ux.intel.com>
> Reviewed-by: Kevin Tian <kevin.tian@...el.com>
> Signed-off-by: Nicolin Chen <nicolinc@...dia.com>
> ---
>  drivers/iommu/fsl_pamu.c        | 2 +-
>  drivers/iommu/fsl_pamu_domain.c | 4 ++--
>  drivers/iommu/intel/pasid.c     | 6 ++++--
>  drivers/iommu/mtk_iommu.c       | 2 +-
>  drivers/iommu/omap-iommu.c      | 4 ++--
>  drivers/iommu/virtio-iommu.c    | 2 +-
>  6 files changed, 11 insertions(+), 9 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

Jason