linux-kernel - Re: [PATCH v3 1/8] cgroup/cpuset: use hotplug_memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0675fe8-14dc-7890-357b-565c0a706932@redhat.com>
Date:   Thu, 22 Sep 2022 19:56:55 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Liu Shixin <liushixin2@...wei.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Waiman Long <longman@...hat.com>,
        Zefan Li <lizefan.x@...edance.com>,
        Christoph Lameter <cl@...ux.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Kefeng Wang <wangkefeng.wang@...wei.com>
Subject: Re: [PATCH v3 1/8] cgroup/cpuset: use hotplug_memory_notifier()
 directly

On 22.09.22 16:18, Liu Shixin wrote:
> Since patch 316346243be6 has already updated the minimum gcc version to 5.1.
> The previous problem mentioned in patch f02c69680088 is not existed. So we
> can now revert to use hotplug_memory_notifier() directly rather than
> register_hotmemory_notifier().
> 
> Signed-off-by: Liu Shixin <liushixin2@...wei.com>
> ---
>   kernel/cgroup/cpuset.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
> index b474289c15b8..0c6db6a4f427 100644
> --- a/kernel/cgroup/cpuset.c
> +++ b/kernel/cgroup/cpuset.c
> @@ -3630,11 +3630,6 @@ static int cpuset_track_online_nodes(struct notifier_block *self,
>   	return NOTIFY_OK;
>   }
>   
> -static struct notifier_block cpuset_track_online_nodes_nb = {
> -	.notifier_call = cpuset_track_online_nodes,
> -	.priority = 10,		/* ??! */
> -};
> -
>   /**
>    * cpuset_init_smp - initialize cpus_allowed
>    *
> @@ -3652,7 +3647,7 @@ void __init cpuset_init_smp(void)
>   	cpumask_copy(top_cpuset.effective_cpus, cpu_active_mask);
>   	top_cpuset.effective_mems = node_states[N_MEMORY];
>   
> -	register_hotmemory_notifier(&cpuset_track_online_nodes_nb);
> +	hotplug_memory_notifier(cpuset_track_online_nodes, 10);
>   
>   	cpuset_migrate_mm_wq = alloc_ordered_workqueue("cpuset_migrate_mm", 0);
>   	BUG_ON(!cpuset_migrate_mm_wq);


Please don't drop Reviewed-by or Acked-by tags. Otherwise reviewers have 
no clue which patch they already reviewed -- and they always have little 
time ;)

-- 
Thanks,

David / dhildenb