linux-kernel - Re: [PATCH linux-next] KVM: selftests: remove redundant variable tsc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9044b55-1498-3309-4db5-70ca2c20b3f7@linuxfoundation.org>
Date:   Thu, 22 Sep 2022 12:45:22 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     cgel.zte@...il.com, pbonzini@...hat.com, shuah@...nel.org,
        seanjc@...gle.com, Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     dmatlack@...gle.com, jmattson@...gle.com, peterx@...hat.com,
        oupton@...gle.com, kvm@...r.kernel.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jinpeng Cui <cui.jinpeng2@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] KVM: selftests: remove redundant variable
 tsc_val

On 8/31/22 08:31, cgel.zte@...il.com wrote:
> From: Jinpeng Cui <cui.jinpeng2@....com.cn>
> 
> Return value directly from expression instead of
> getting value from redundant variable tsc_val.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Jinpeng Cui <cui.jinpeng2@....com.cn>
> ---
>   tools/testing/selftests/kvm/include/x86_64/processor.h | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/kvm/include/x86_64/processor.h b/tools/testing/selftests/kvm/include/x86_64/processor.h
> index 0cbc71b7af50..75920678f34d 100644
> --- a/tools/testing/selftests/kvm/include/x86_64/processor.h
> +++ b/tools/testing/selftests/kvm/include/x86_64/processor.h
> @@ -237,7 +237,6 @@ static inline uint64_t get_desc64_base(const struct desc64 *desc)
>   static inline uint64_t rdtsc(void)
>   {
>   	uint32_t eax, edx;
> -	uint64_t tsc_val;
>   	/*
>   	 * The lfence is to wait (on Intel CPUs) until all previous
>   	 * instructions have been executed. If software requires RDTSC to be
> @@ -245,8 +244,8 @@ static inline uint64_t rdtsc(void)
>   	 * execute LFENCE immediately after RDTSC
>   	 */
>   	__asm__ __volatile__("lfence; rdtsc; lfence" : "=a"(eax), "=d"(edx));
> -	tsc_val = ((uint64_t)edx) << 32 | eax;
> -	return tsc_val;
> +
> +	return ((uint64_t)edx) << 32 | eax;
>   }
>   
>   static inline uint64_t rdtscp(uint32_t *aux)

My understanding is that this patch isn't coming from individuals that work
for ZTE. We won't be able to accept these patches. Refer to the following
for reasons why we can't accept these patches.

https://patchwork.kernel.org/project/linux-kselftest/patch/20220920063202.215088-1-ye.xingchen@zte.com.cn/

thanks,
-- Shuah