linux-kernel - [PATCH] x86/cpu: Include missing header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Sep 2022 17:00:54 -0300
From:   Luciano Leão <lucianorsleao@...il.com>
To:     seanjc@...gle.com, bp@...e.de, tglx@...utronix.de
Cc:     linux-kernel@...r.kernel.org, n@...aprado.net,
        mairacanal@...eup.net, isabbasso@...eup.net,
        andrealmeid@...eup.net,
        Luciano Leão <lucianorsleao@...il.com>
Subject: [PATCH] x86/cpu: Include missing header

Include the header containing the prototype of a global function,
solving the following warning:

 arch/x86/kernel/cpu/feat_ctl.c:112:6: warning: no previous prototype for
 'init_ia32_feat_ctl'
 [-Wmissing-prototypes]

This warning appeared after commit 5d5103595e9e5 ("x86/cpu: Reinitialize
IA32_FEAT_CTL MSR on BSP during wakeup") had moved function
init_ia32_feat_ctl()'s prototype from arch/x86/kernel/cpu/cpu.h to
arch/x86/include/asm/cpu.h.

Note that, before the commit mentioned above, header "cpu.h"
(arch/x86/kernel/cpu/cpu.h) was added by commit 0e79ad863df43 ("x86/cpu:
Fix a -Wmissing-prototypes warning for init_ia32_feat_ctl()")
solely to fix init_ia32_feat_ctl()'s missing prototype. So, header
"cpu.h" is no longer necessary.

Fixes: 5d5103595e9e5 ("x86/cpu: Reinitialize IA32_FEAT_CTL MSR on BSP during wakeup")
Reviewed-by: Nícolas F. R. A. Prado <n@...aprado.net>
Signed-off-by: Luciano Leão <lucianorsleao@...il.com>
---
 arch/x86/kernel/cpu/feat_ctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/feat_ctl.c b/arch/x86/kernel/cpu/feat_ctl.c
index 993697e71854..03851240c3e3 100644
--- a/arch/x86/kernel/cpu/feat_ctl.c
+++ b/arch/x86/kernel/cpu/feat_ctl.c
@@ -1,11 +1,11 @@
 // SPDX-License-Identifier: GPL-2.0
 #include <linux/tboot.h>

+#include <asm/cpu.h>
 #include <asm/cpufeature.h>
 #include <asm/msr-index.h>
 #include <asm/processor.h>
 #include <asm/vmx.h>
-#include "cpu.h"

 #undef pr_fmt
 #define pr_fmt(fmt)	"x86/cpu: " fmt
-- 
2.30.2