linux-kernel - Re: [PATCH net-next v6 5/7] ethtool: add interface to interact with Ethernet Power Equipment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YyvYOcfrur2mQXGl@debian.me>
Date:   Thu, 22 Sep 2022 10:36:25 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Oleksij Rempel <o.rempel@...gutronix.de>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Russell King <linux@...linux.org.uk>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jonathan Corbet <corbet@....net>,
        kernel test robot <lkp@...el.com>, kernel@...gutronix.de,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
        David Jander <david@...tonic.nl>,
        Luka Perkov <luka.perkov@...tura.hr>,
        Robert Marko <robert.marko@...tura.hr>
Subject: Re: [PATCH net-next v6 5/7] ethtool: add interface to interact with
 Ethernet Power Equipment

On Wed, Sep 21, 2022 at 02:47:45PM +0200, Oleksij Rempel wrote:
> +PSE_GET
> +=======
> +
> +Gets PSE attributes.
> +
> +Request contents:
> +
> +  =====================================  ======  ==========================
> +  ``ETHTOOL_A_PSE_HEADER``               nested  request header
> +  =====================================  ======  ==========================
> +
> +Kernel response contents:
> +
> +  ======================================  ======  =============================
> +  ``ETHTOOL_A_PSE_HEADER``                nested  reply header
> +  ``ETHTOOL_A_PODL_PSE_ADMIN_STATE``         u32  Operational state of the PoDL
> +                                                  PSE functions
> +  ``ETHTOOL_A_PODL_PSE_PW_D_STATUS``         u32  power detection status of the
> +                                                  PoDL PSE.
> +  ======================================  ======  =============================
> +
> +When set, the optional ``ETHTOOL_A_PODL_PSE_ADMIN_STATE`` attribute identifies
> +the operational state of the PoDL PSE functions.  The operational state of the
> +PSE function can be changed using the ``ETHTOOL_A_PODL_PSE_ADMIN_CONTROL``
> +action. This option is corresponding to IEEE 802.3-2018 30.15.1.1.2
> +aPoDLPSEAdminState. Possible values are:

The IEEE 802.3-2018 keyword name can be enclosed within inline code block.

> +When set, the optional ``ETHTOOL_A_PODL_PSE_PW_D_STATUS`` attribute identifies
> +the power detection status of the PoDL PSE.  The status depend on internal PSE
> +state machine and automatic PD classification support. This option is
> +corresponding to IEEE 802.3-2018 30.15.1.1.3 aPoDLPSEPowerDetectionStatus.

Same here.

> +When set, the optional ``ETHTOOL_A_PODL_PSE_ADMIN_CONTROL`` attribute is used
> +to control PoDL PSE Admin functions. This option is implementing
> +IEEE 802.3-2018 30.15.1.2.1 acPoDLPSEAdminControl. See

Same here too.

Otherwise LGTM.

Reviewed-by: Bagas Sanjaya <bagasdotme@...il.com>

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)